Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DownloadCssFile #12

Open
markgibbons25 opened this issue Jun 8, 2021 · 1 comment
Open

DownloadCssFile #12

markgibbons25 opened this issue Jun 8, 2021 · 1 comment

Comments

@markgibbons25
Copy link

I have a couple questions around the implementation here,

  • Why does it download the optimized css file via HTTP request instead of downloading the optimized media item blob via the SXA IAssetBundler? (I ran into an issue here when using a CDN.)
  • Is this globally disabling certificate checks intended? If so perhaps it should be re-enabled after the request?

Thanks for publishing this module mate.

@TomTyack
Copy link
Contributor

Hey Mark,

Sorry been a bit since I checked my github notifications.

  • With the HTTP request, it was the quickest win I could spot at the time. Just had a look under the hood at Sitecore.XA.Foundation.Theming.Bundler.AssetBundler and your right it looks like you can get to the CSS content directly from the Theme. I hadn't tried it via a CDN to be honest, but I can see how it might cause issues. I'll give this a go when I get a chance.

  • The certificate disabler is probably something that slipped through in the last re-write. I just removed the RestSharp dependency and its code. I might wrap that certificate disabler in a debug only mode check.

Thanks for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants