pwmout is 16bit only which means a max period of .2s

[jacobrosenthal]

Using my target, but Ive confirmed this on the mkit-gcc target as well.

PERIOD is defined as a uint16_t even though NRF_TIMER_Type.CC is defined as a uint32_t
PERIOD thus maxes out at 65535 or 0.26214f which seems short as the PWMOUT example sets a 4.0f, or 4 second period

I think theres more broken than that though, because even if I

• make PERIOD a uint32_t
• change these lines appropriately https://github.com/ARMmbed/mbed-hal-nrf51822-mcu/blob/master/source/pwmout_api.c#L304-L305
• and confirm that setting led.period(4.0f); leads to a PERIOD of 1000000

An LED still blinks way to fast. So I think theres more issues in here than Ive currently found.

[ciarmcom]

ARM Internal Ref: IOTSFW-1911

[ghost]

@jacobrosenthal : how does this compare to the same code in https://github.com/mbedmicro/mbed ? I don't have time to investigate myself, but worth a look.

[jacobrosenthal]

The same, as I presume it was copied from there. There dont appear to be
any real changes in the history of this file either.

On Tue, Jan 26, 2016 at 2:29 AM, Johnny Robeson [email protected]
wrote:

@jacobrosenthal https://github.com/jacobrosenthal : how does this
compare to the same code in https://github.com/mbedmicro/mbed ? I don't
have time to investigate myself, but worth a look.

—
Reply to this email directly or view it on GitHub
#42 (comment)
.

[ghost]

I wonder if that would also help fix this issue ARMmbed/mbed-os#1378

I still am not sure of the way fixes in these yotta modules propagate to and/or from mbedmicro/mbed, since such a fix would be needed there as well.

[jacobrosenthal]

Is timer0 (the one reserved by the softdevice) the 32 bit timer?

[ghost]

I think that's what it says about timer0 here: http://infocenter.nordicsemi.com/topic/com.nordic.infocenter.pdf.ps/nRF51822_PS_v3.1.pdf

[ghost]

can someone from mbed describe how a fix here should make its way to mbedmicro/mbed ?

[jacobrosenthal]

No comment from the team, but my guess is this looks to be 'fixed' by the introduction of the nrf52
http://infocenter.nordicsemi.com/pdf/nRF52_Series_Migration_v1.0.pdf

Additional timer instances are added, TIMER3 and TIMER4. All timers now support all bit
modes (8, 16, 24, and 32 bits)