Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ants/segmentation/label_geometry_measures.py will need updating when ANTs version is bumped #612

Open
cookpa opened this issue May 2, 2024 · 7 comments

Comments

@cookpa
Copy link
Member

cookpa commented May 2, 2024

Physical volume of labels will be included in the output after merging

ANTsX/ANTs#1737

Currently, label_geometry_measures.py creates this on the fly.

@stnava
Copy link
Member

stnava commented May 2, 2024

agree - just want the "new" version to "look like" the old one ... extra / new entries are ok but if it's possible to maintain the same naming - that would be very helpful.

@cookpa
Copy link
Member Author

cookpa commented May 2, 2024

Understood

@cookpa
Copy link
Member Author

cookpa commented May 2, 2024

OK used the column name "VolumeInMillimeters", Flatlanders will have to deal.

Now the only change required will be to not duplicate the "VolumeInMillimeters" column in the function, since it will already be there.

@ntustison
Copy link
Member

yeah, i've seen that and i'm guessing it was my fault. would this be a problem @stnava if we fixed it?

@stnava
Copy link
Member

stnava commented May 3, 2024

here is the check if it will be a problem:

run :

old=ants.label_geometry_measures( some_labels, some_intensity )
new=ants.label_geometry_measures( some_labels, some_intensity, param=new_filter )
should_be_true( names(old) %in% names(new) )

are they the same? at least conceptually - that's the idea. ie if someone expects to get a variable name - they should get it and it should be correct.

@cookpa
Copy link
Member Author

cookpa commented May 3, 2024

Some of the variables don't exist in the supported filter, but the ones that do are named the same now

@cookpa
Copy link
Member Author

cookpa commented May 5, 2024

Further update: I added back eccentricity and Axes length. Got everything except weighted centroid now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants