Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EM, Z from enter_target/leave_target #2872

Open
tokatoka opened this issue Jan 20, 2025 · 0 comments
Open

Remove EM, Z from enter_target/leave_target #2872

tokatoka opened this issue Jan 20, 2025 · 0 comments
Milestone

Comments

@tokatoka
Copy link
Member

tokatoka commented Jan 20, 2025

This is very important.
We need to fix this as soon as possible.
The bug in #2858 was caused by this.
Probably I'll do but i'll open here so that i don't forget

    #[inline]
    pub unsafe fn enter_target<EM, Z>(
        &mut self,
        fuzzer: &mut Z,
        state: &mut S,
        mgr: &mut EM,
        input: &I,
        executor_ptr: *const c_void,
    )

and

    /// This function marks the boundary between the fuzzer and the target
    #[inline]
    pub fn leave_target<EM, Z>(
        &mut self,
        _fuzzer: &mut Z,
        _state: &mut S,
        _mgr: &mut EM,
        _input: &I,
    )

EM and Z should be gone

I explained why this is bad in #2858 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant