Cleanup #329
Merged
Cleanup #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Etienne-Buschong
approved these changes
Jul 31, 2024
Replaced all usages of Array.isArray with a custom utility that fixes its types. Using Array.isArray() on a value that can either be a ReadonlyArray or something else actuall narrows the value down to any[], which can be dangerous. Looks like our isReadonlyArray is even safe to use for mutable array types. BREAKING CHANGE: some APIs that previously used mutable arrays are now typed as ReadonlyArray.
getEnumTypes() actually had a wrong type signature, which TS 5.5 is able to report as an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.