feat: add @hidden directive on fields #315

Etienne-Buschong · 2024-03-19T16:38:14Z

No description provided.

Yogu · 2024-03-20T07:08:46Z

can you add tests tests

(probably best in the ast-validation-modules directory) for when a system field is considered redundant or not, and for whether the types are correct?
in create-model.spec.ts for the system overrides including e.g. updatedAt: isHidden (there already is one for id: ID @key
for isHidden in the meta schema

src/model/create-model.ts

src/model/implementation/object-type-base.ts

src/schema/graphql-base.ts

src/model/implementation/object-type-base.ts

Yogu · 2024-03-20T17:33:11Z

tests are good

spec/meta-schema/meta-schema.spec.ts

Yogu · 2024-03-21T15:25:22Z

aside from the suggestion and the merge conflict it's ready I think, feel free to merge afterwards

Yogu reviewed Mar 20, 2024

View reviewed changes

Etienne-Buschong force-pushed the add-hidden-directive branch 4 times, most recently from 0f50790 to 754dee5 Compare March 20, 2024 12:48

Yogu reviewed Mar 20, 2024

View reviewed changes

spec/meta-schema/meta-schema.spec.ts Outdated Show resolved Hide resolved

spec/meta-schema/meta-schema.spec.ts Show resolved Hide resolved

Etienne-Buschong force-pushed the add-hidden-directive branch from 754dee5 to fc67b7d Compare March 21, 2024 09:17

feat: add @hidden directive on fields

f3aa37a

Etienne-Buschong force-pushed the add-hidden-directive branch from fc67b7d to f3aa37a Compare March 28, 2024 10:42

Etienne-Buschong merged commit 86ce3ca into main Mar 28, 2024
28 checks passed

Yogu deleted the add-hidden-directive branch January 31, 2025 13:35

Provide feedback