feat: add raw localizations to meta types, fields and enums #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yogu
reviewed
Mar 19, 2024
Etienne-Buschong
force-pushed
the
meta-field-localizations-i18n-string
branch
from
7924603 to
ba10b81
Compare
|
Can be reviewed again. |
|
Should I also add tests in |
ah yes please, forgot about them here. You could probably also add some unit tests that query the properties in the |
Etienne-Buschong
force-pushed
the
meta-field-localizations-i18n-string
branch
from
ba10b81 to
65445d6
Compare
|
Added the tests. |
Yogu
approved these changes
Mar 20, 2024
| @@ -939,6 +1024,84 @@ describe('Meta schema API', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it('can query raw localization of types', async () => { | |||
There was a problem hiding this comment.
maybe add a test for a field where only one of the languages is present, to make sure the value omits this key then?
There was a problem hiding this comment.
added a test for a field on the root entity type and a value object, both with only german translations
Currently, it is only possible to query localizations by explicitly specifying the target language for the client. There are also use-cases where the localization is not immediately used in a client, but needed to be processed in another system. In this case it is convenient to be able to query the translations in all locales in a single request.
Etienne-Buschong
force-pushed
the
meta-field-localizations-i18n-string
branch
from
65445d6 to
4b98144
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it is only possible to query localizations by explicitly specifying the target language for the client. There are also use-cases where the localization is not immediately used in a client, but needed to be processed in another system. In this case it is convenient to be able to query the translations in all locales in a single request.