Skip to content

Commit

Permalink
ci: test with ArangoDB 3.12
Browse files Browse the repository at this point in the history
With ArangoDB 3.12, we now need to configure the locale because without it
specified, the sort order of strings would change

    for a in ["Scal", "PART", "part"] sort a return a

before:

    [
      "PART",
      "part",
      "Scal"
    ]

with 3.12 but without locale

    [
      "PART",
      "Scal",
      "part"
    ]

with 3.12, and locale specified (--icu-language en_US.UTF-8)

    [
      "PART",
      "part",
      "Scal"
    ]
  • Loading branch information
Yogu committed May 13, 2024
1 parent 86ce3ca commit 92bbdde
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
11 changes: 9 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,14 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
arango-image: ['arangodb:3.8', 'arangodb:3.9', 'arangodb:3.10', 'arangodb:3.11']
arango-image:
[
"arangodb:3.8",
"arangodb:3.9",
"arangodb:3.10",
"arangodb:3.11",
"arangodb:3.12",
]
node-version: [14.x, 16.x, 18.x]
steps:
- uses: actions/checkout@v2
Expand All @@ -15,7 +22,7 @@ jobs:
node-version: ${{ matrix.node-version }}
- run:
docker run --name arangodb -p 127.0.0.1:8529:8529 -d -e ARANGO_NO_AUTH=1 ${{
matrix.arango-image }}
matrix.arango-image }} --icu-language en_US.UTF-8
- run: timeout 10 docker logs --follow arangodb || true # wait until arangodb is started
- run: curl -L http://localhost:8529/_api/version
- run: npm ci
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -140,3 +140,4 @@ cruddl currently supports the following versions of ArangoDB:
- 3.9
- 3.10
- 3.11
- 3.12

0 comments on commit 92bbdde

Please sign in to comment.