Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constant OUTPUT_BUFFER capacity can cause crashes #2

Closed
ABCxFF opened this issue Sep 28, 2022 · 1 comment · Fixed by #55
Closed

Constant OUTPUT_BUFFER capacity can cause crashes #2

ABCxFF opened this issue Sep 28, 2022 · 1 comment · Fixed by #55
Assignees
@Nul-led
Labels
critical High relevance vulnerabilities that can cause harm to the server or its clients

Comments

@ABCxFF
Copy link
Owner

ABCxFF commented Sep 28, 2022 •
edited
Loading

Once compressor is built (waiting on #1), deal with this maximum output buffer capacity.

https://github.com/ABCxFF/diepcustom/blob/main/src/Coder/Writer.ts#L25

As of now, server crashes if u see enough objects be made at once (only happens when on high FOV so it doesn't matter much anyway).
@ABCxFF ABCxFF added the wontfix Means the issue is not an issue label Sep 28, 2022
@Nul-led
Copy link
Collaborator

Nul-led commented Oct 2, 2022 •
edited
Loading

possible quick fix might be to split large fovs/packets into parts.. idk if the client accepts 2 0x00 packets with the same tick

@ABCxFF ABCxFF added critical High relevance vulnerabilities that can cause harm to the server or its clients and removed wontfix Means the issue is not an issue labels Oct 11, 2022
ABCxFF added a commit that referenced this issue Nov 11, 2022
@ABCxFF
patch: #2
bd17605
@ABCxFF ABCxFF mentioned this issue Nov 11, 2022
Merged
1 task
ABCxFF added a commit that referenced this issue Nov 13, 2022
@ABCxFF
finish #2, using fin
fe25ace
ABCxFF added a commit that referenced this issue Nov 13, 2022
@ABCxFF
patch: fix (#44,#49,#50,#2, #4) (PR #55)
912badc 
* patch: #2

* patch #44

* patch #49 - make specs invisible

* patch #50 -

* use buffers for writing

* Revert 00 chunking

* also patch #4

* finish #2, using fin
Camvanaa pushed a commit to Camvanaa/diepcustom that referenced this issue Jan 12, 2025
@ABCxFF
patch: fix (ABCxFF#44,ABCxFF#49,ABCxFF#50,ABCxFF#2, ABCxFF#4) (PR ABC…
2878aea 
…xFF#55)

* patch: ABCxFF#2

* patch ABCxFF#44

* patch ABCxFF#49 - make specs invisible

* patch ABCxFF#50 -

* use buffers for writing

* Revert 00 chunking

* also patch ABCxFF#4

* finish ABCxFF#2, using fin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nul-led Nul-led

Labels
critical High relevance vulnerabilities that can cause harm to the server or its clients
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Minor patches(#44,#49,#50,#2, #4) ABCxFF/diepcustom
2 participants
@Nul-led @ABCxFF