Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offset calculation for solo BIOS region is wrong. #393

Open
werwurm opened this issue Oct 18, 2024 · 0 comments
Open

Offset calculation for solo BIOS region is wrong. #393

werwurm opened this issue Oct 18, 2024 · 0 comments

Comments

@werwurm
Copy link
Contributor

werwurm commented Oct 18, 2024

return consts.BasePhysAddr - addr, nil

This calculates the offset from the end of the image, but what we need is the offset from the beginning of the image.

return <image size likely 16MB> - (consts.BasePhysAddr - addr), nil

I hard coded this to 16MB (0x1000000) for my image and it worked like a charm. The real fix probably needs to use the actual image size.

This is how the problem manifested, just in case someone is searching for this issue:

bg-prov: error: new ACM size doesn't equal old ACM size

return consts.BasePhysAddr - addr, nil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant