Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too much screams at the same time #10

Open
SourCreamKun opened this issue Jun 2, 2021 · 7 comments
Open

Too much screams at the same time #10

SourCreamKun opened this issue Jun 2, 2021 · 7 comments
Labels
bug Something isn't working

Comments

@SourCreamKun
Copy link

I am writing code on Node Js now, and on every line when I start typing it is yelling on my every letter I type with several voices and phrases, can you just make it pronounce one phrase at time or smt?

@89netraM 89netraM self-assigned this Jun 3, 2021
@89netraM 89netraM added the bug Something isn't working label Jun 3, 2021
@89netraM
Copy link
Owner

89netraM commented Jun 3, 2021

Hmm, yes. That is a problem. I have a system in place for preventing this, and I don't encounter it.
If I update that system, could you test it before I merge and publish it?

@89netraM
Copy link
Owner

89netraM commented Jun 3, 2021

Okay it was an easy change. It works the same for me, but it should wait until the whole audio clip is played before starting a new now.

I've attached a .vsix (in the .zip) that you can install on your system to test it. If your running Linux you'll have to build yourself, look in the prevent-overlapping branch for the updates.

hotheaded-vscode-1.1.3.zip

@SourCreamKun
Copy link
Author

Well, it works pretty much fine, but there is some annoying sound, like turning off old radio, at the end of every clip, and sometimes there are 2 of voices, but i have to type very badly for that to happen

@89netraM
Copy link
Owner

89netraM commented Jun 3, 2021

Other people have complained about that sound before, but I've never heard it so it's a bit difficult to debug.
And based on the still overlapping voices I guess the fix didn't fix that much.

I don't know how to continue with this. If you want to take look yourself, everything related to the playback of audio is in the ./src/Player.ts file.

@89netraM 89netraM removed their assignment Jun 3, 2021
@SourCreamKun
Copy link
Author

Maybe if you add a seccond or two silence between clips, it will be ok ? I thin it could solve the problem of strange sound and do better effect on overlapping pervention

@SourCreamKun
Copy link
Author

I mean not a clip with silence, but wait between clips

@NinjaZMY
Copy link

NinjaZMY commented Aug 18, 2024

@89netraM
can you make it one clip at a time, still dysfunctional
make it like rainbow-fart the extension one sound at a time,

add a trigger , only one sound can be used by the trigger , for example a global boolean variable "SoundPlaying"

if (trigger & !SoundPlaying) // on trigger and no actual sound is playing
PlayRandomSound()

if the sound Finished playing, "SoundPlaying=false", enabling the trigger to be triggered

This should Render one sound at the time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants