From 0fce0380ffd88a605f69bc420be5c734ec61cbad Mon Sep 17 00:00:00 2001 From: Anton Agestam Date: Tue, 2 Nov 2021 15:05:13 +0100 Subject: [PATCH] Don't pass comment as status description (#27) --- dist/index.js | 12 +++++++----- src/action.js | 12 +++++++----- 2 files changed, 14 insertions(+), 10 deletions(-) diff --git a/dist/index.js b/dist/index.js index 84b3dd48..6ddb25c4 100644 --- a/dist/index.js +++ b/dist/index.js @@ -11393,6 +11393,10 @@ function getReviewFailEvent() { const REVIEW_APPROVE = "APPROVE"; const REVIEW_COMMENT = "COMMENT"; const REVIEW_REQUEST_CHANGES = "REQUEST_CHANGES"; +const STATUS_FAILURE = "failure"; +const STATUS_SUCCESS = "success"; +const DESCRIPTION_SUCCESS = "Valid release."; +const DESCRIPTION_FAILURE = "Invalid release."; async function review(pullRequest, event, comment) { core.info(`Reviewing ${pullRequest.number}..`); @@ -11403,16 +11407,14 @@ async function review(pullRequest, event, comment) { ...github.context.repo }); // Set status on commit + const state = event === REVIEW_APPROVE; await setStatus( pullRequest, - event === REVIEW_APPROVE ? STATUS_SUCCESS : STATUS_FAILURE, - comment + state ? STATUS_SUCCESS : STATUS_FAILURE, + state ? DESCRIPTION_SUCCESS : DESCRIPTION_FAILURE ); } -const STATUS_FAILURE = "failure"; -const STATUS_SUCCESS = "success"; - async function setStatus(pullRequest, state, description) { core.info(`Setting status ${state}..`); const createStatus = JSON.parse( diff --git a/src/action.js b/src/action.js index 3ea40e7f..d67846d2 100644 --- a/src/action.js +++ b/src/action.js @@ -214,6 +214,10 @@ function getReviewFailEvent() { const REVIEW_APPROVE = "APPROVE"; const REVIEW_COMMENT = "COMMENT"; const REVIEW_REQUEST_CHANGES = "REQUEST_CHANGES"; +const STATUS_FAILURE = "failure"; +const STATUS_SUCCESS = "success"; +const DESCRIPTION_SUCCESS = "Valid release."; +const DESCRIPTION_FAILURE = "Invalid release."; async function review(pullRequest, event, comment) { core.info(`Reviewing ${pullRequest.number}..`); @@ -224,16 +228,14 @@ async function review(pullRequest, event, comment) { ...github.context.repo }); // Set status on commit + const state = event === REVIEW_APPROVE; await setStatus( pullRequest, - event === REVIEW_APPROVE ? STATUS_SUCCESS : STATUS_FAILURE, - comment + state ? STATUS_SUCCESS : STATUS_FAILURE, + state ? DESCRIPTION_SUCCESS : DESCRIPTION_FAILURE ); } -const STATUS_FAILURE = "failure"; -const STATUS_SUCCESS = "success"; - async function setStatus(pullRequest, state, description) { core.info(`Setting status ${state}..`); const createStatus = JSON.parse(