From 0e21d5e2420038e06d9f630d603e58a87b37527c Mon Sep 17 00:00:00 2001
From: Dan Green <danngreen1@gmail.com>
Date: Mon, 6 Nov 2023 08:39:07 -0800
Subject: [PATCH] Fix os in vcv-tests workflow. Fix firmware workflow uploading
 elf file

---
 .github/workflows/build_test_firmware.yml | 2 +-
 .github/workflows/run_vcv_tests.yml       | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/build_test_firmware.yml b/.github/workflows/build_test_firmware.yml
index 71ceaee5d..264f0e28b 100644
--- a/.github/workflows/build_test_firmware.yml
+++ b/.github/workflows/build_test_firmware.yml
@@ -60,6 +60,7 @@ jobs:
           echo "AudibleInstruments:Braids" >> firmware/lim
           cd firmware && make limit lim && make all
 
+      # Don't upload artifacts for each build, uses too much space on our account
       # - name: Upload artifact
       #   uses: actions/upload-artifact@v3
       #   with:
@@ -74,6 +75,5 @@ jobs:
         with:
           name: "Firmware Version: ${{ env.CI_REF_NAME }}"
           files: |
-            firmware/build/mp1corea7/medium/main.elf
             firmware/build/mp1corea7/medium/main.uimg
 
diff --git a/.github/workflows/run_vcv_tests.yml b/.github/workflows/run_vcv_tests.yml
index 878921c6e..56c5baea1 100644
--- a/.github/workflows/run_vcv_tests.yml
+++ b/.github/workflows/run_vcv_tests.yml
@@ -11,7 +11,7 @@ on:
       win_x64:
         description: 'Run tests on Windows x64'
         required: true
-        default: true
+        default: false
         type: boolean
       # mac_x64:
       #   description: 'Run tests on Mac x64'
@@ -76,7 +76,7 @@ jobs:
   build-tests-win-x64:
     if: ${{ inputs.win_x64 }} #Only run msys2 test manually
     name: win-x64
-    runs-on: ubuntu-latest
+    runs-on: windows-latest
     strategy:
       fail-fast: false
     defaults: