Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodeJS bindings seem to have broken #313

Open
shahchintan14 opened this issue Apr 8, 2023 · 1 comment
Open

NodeJS bindings seem to have broken #313

shahchintan14 opened this issue Apr 8, 2023 · 1 comment
Assignees
@vijaiaeroastro
Labels
bindings
Milestone
2.4.0

Comments

@shahchintan14
Copy link

Running the command as per instruction in nodejs example gives error.

node-gyp rebuild --verbose binding.gyp

lib3mf\Autogenerated\Bindings\NodeJS\lib3mf_nodewrapper.h(66,40): error C2039: 'Handle': is not a member of 'v8' [lib3mf\Autogenerated\Bindings\NodeJS\build\lib3mf_nodeaddon.vcxproj]

and many such errors
@vijaiaeroastro vijaiaeroastro self-assigned this Jun 1, 2024
@vijaiaeroastro vijaiaeroastro added this to the 2.4.0 milestone Aug 19, 2024
@vijaiaeroastro
Copy link
Collaborator

Related to #321

vijaiaeroastro added a commit that referenced this issue Sep 3, 2024
@vijaiaeroastro
Merge branch 'vijai/fix_nodejs_bindings' of github.com:3MFConsortium/…
633bf36 
…lib3mf into vijai/fix_nodejs_bindings #313 #321
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vijaiaeroastro vijaiaeroastro

Labels
bindings
Projects
None yet
Milestone
2.4.0
Development

No branches or pull requests
2 participants
@vijaiaeroastro @shahchintan14