Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust rust pwchan error severity level #6490

Open
mreynolds389 opened this issue Jan 9, 2025 · 2 comments · May be fixed by #6496
Open

Adjust rust pwchan error severity level #6490

mreynolds389 opened this issue Jan 9, 2025 · 2 comments · May be fixed by #6496
Assignees
@mreynolds389 @droideck
Labels
needs triage The issue will be triaged during scrum rust Rust language

Comments

@mreynolds389
Copy link
Contributor

Issue Description

We log an info message about the pbkdf2 iterations, but the severity level is ERR, when it should be INFO.
@mreynolds389 mreynolds389 added needs triage The issue will be triaged during scrum rust Rust language labels Jan 9, 2025
@mreynolds389 mreynolds389 self-assigned this Jan 9, 2025
mreynolds389 added a commit to mreynolds389/389-ds-base that referenced this issue Jan 9, 2025
@mreynolds389
Issue 6490 - Adjust rust pwchan error severity level
ad7ac49 
Description:

We log an info message about the pbkdf2 iterations, but the severity level is
ERR, when it should be INFO.

Relates: 389ds#6490

Reviewed by: ?
@mreynolds389 mreynolds389 mentioned this issue Jan 9, 2025
Merged
mreynolds389 added a commit to mreynolds389/389-ds-base that referenced this issue Jan 9, 2025
@mreynolds389
Issue 6490 - Adjust rust pwchan error severity level
9b8d3c2 
Description:

We log an info message about the pbkdf2 iterations, but the severity level is
ERR. Just removing the logging for now, and it will added back later at
a more appropriate location.

Relates: 389ds#6490

Reviewed by: spichugi(Thanks!)
mreynolds389 added a commit to mreynolds389/389-ds-base that referenced this issue Jan 9, 2025
@mreynolds389
Issue 6490 - Adjust rust pwchan error severity level
98371d7 
Description:

We log an info message about the pbkdf2 iterations, but the severity level is
ERR. Just removing the logging for now, and it will added back later at
a more appropriate location.

Relates: 389ds#6490

Reviewed by: spichugi(Thanks!)
mreynolds389 added a commit to mreynolds389/389-ds-base that referenced this issue Jan 11, 2025
@mreynolds389
Issue 6490 - Remove the rust error log message for pbkdf2 rounds
5aec7f0 
Description:

We log an info message about the pbkdf2 iterations, but the severity level is
ERR. Just removing the logging for now, and it will added back later at
a more appropriate location.

Relates: 389ds#6490

Reviewed by: spichugi(Thanks!)
mreynolds389 added a commit that referenced this issue Jan 11, 2025
@mreynolds389
Issue 6490 - Remove the rust error log message for pbkdf2 rounds
f2abeb0 
Description:

We log an info message about the pbkdf2 iterations, but the severity level is
ERR. Just removing the logging for now, and it will added back later at
a more appropriate location.

Relates: #6490

Reviewed by: spichugi(Thanks!)
mreynolds389 added a commit that referenced this issue Jan 11, 2025
@mreynolds389
Issue 6490 - Remove the rust error log message for pbkdf2 rounds
53eb367 
Description:

We log an info message about the pbkdf2 iterations, but the severity level is
ERR. Just removing the logging for now, and it will added back later at
a more appropriate location.

Relates: #6490

Reviewed by: spichugi(Thanks!)
mreynolds389 added a commit that referenced this issue Jan 11, 2025
@mreynolds389
Issue 6490 - Remove the rust error log message for pbkdf2 rounds
1791209 
Description:

We log an info message about the pbkdf2 iterations, but the severity level is
ERR. Just removing the logging for now, and it will added back later at
a more appropriate location.

Relates: #6490

Reviewed by: spichugi(Thanks!)
mreynolds389 added a commit that referenced this issue Jan 11, 2025
@mreynolds389
Issue 6490 - Remove the rust error log message for pbkdf2 rounds
661fdef 
Description:

We log an info message about the pbkdf2 iterations, but the severity level is
ERR. Just removing the logging for now, and it will added back later at
a more appropriate location.

Relates: #6490

Reviewed by: spichugi(Thanks!)
mreynolds389 added a commit that referenced this issue Jan 11, 2025
@mreynolds389
Issue 6490 - Remove the rust error log message for pbkdf2 rounds
a330c4e 
Description:

We log an info message about the pbkdf2 iterations, but the severity level is
ERR. Just removing the logging for now, and it will added back later at
a more appropriate location.

Relates: #6490

Reviewed by: spichugi(Thanks!)
mreynolds389 added a commit that referenced this issue Jan 11, 2025
@mreynolds389
Issue 6490 - Remove the rust error log message for pbkdf2 rounds
798f3f1 
Description:

We log an info message about the pbkdf2 iterations, but the severity level is
ERR. Just removing the logging for now, and it will added back later at
a more appropriate location.

Relates: #6490

Reviewed by: spichugi(Thanks!)
mreynolds389 added a commit that referenced this issue Jan 11, 2025
@mreynolds389
Issue 6490 - Remove the rust error log message for pbkdf2 rounds
67dad3e 
Description:

We log an info message about the pbkdf2 iterations, but the severity level is
ERR. Just removing the logging for now, and it will added back later at
a more appropriate location.

Relates: #6490

Reviewed by: spichugi(Thanks!)
mreynolds389 added a commit that referenced this issue Jan 11, 2025
@mreynolds389
Issue 6490 - Remove the rust error log message for pbkdf2 rounds
3d7d2ec 
Description:

We log an info message about the pbkdf2 iterations, but the severity level is
ERR. Just removing the logging for now, and it will added back later at
a more appropriate location.

Relates: #6490

Reviewed by: spichugi(Thanks!)
mreynolds389 added a commit that referenced this issue Jan 11, 2025
@mreynolds389
Issue 6490 - Remove the rust error log message for pbkdf2 rounds
7bc52cc 
Description:

We log an info message about the pbkdf2 iterations, but the severity level is
ERR. Just removing the logging for now, and it will added back later at
a more appropriate location.

Relates: #6490

Reviewed by: spichugi(Thanks!)
mreynolds389 added a commit that referenced this issue Jan 11, 2025
@mreynolds389
Issue 6490 - Remove the rust error log message for pbkdf2 rounds
4716a55 
Description:

We log an info message about the pbkdf2 iterations, but the severity level is
ERR. Just removing the logging for now, and it will added back later at
a more appropriate location.

Relates: #6490

Reviewed by: spichugi(Thanks!)
@mreynolds389
Copy link
Contributor Author

90163fb..53eb367 389-ds-base-3.0 -> 389-ds-base-3.0
41d5e9a..1791209 389-ds-base-2.6 -> 389-ds-base-2.6
afce4f1..661fdef 389-ds-base-2.5 -> 389-ds-base-2.5
2ddd04e..a330c4e 389-ds-base-2.4 -> 389-ds-base-2.4
20d41f8..798f3f1 389-ds-base-2.3 -> 389-ds-base-2.3
82339aa..67dad3e 389-ds-base-2.2 -> 389-ds-base-2.2
0a0f188..3d7d2ec 389-ds-base-2.1 -> 389-ds-base-2.1
f588086..7bc52cc 389-ds-base-2.0 -> 389-ds-base-2.0
04df2c8..4716a55 389-ds-base-1.4.3 -> 389-ds-base-1.4.3

@droideck droideck self-assigned this Jan 11, 2025
@droideck droideck reopened this Jan 11, 2025
@droideck
Copy link
Member

droideck commented Jan 11, 2025 •
edited
Loading

There's already a message like this in the errors log:
[09/Jan/2025:15:07:44.412945844 -0500] - INFO - PBKDF2_SHA256 - Based on CPU performance, chose 2048 rounds

We need to add a similar message to the instance start-up for PBKDF2-* iterations.

droideck added a commit to droideck/389-ds-base that referenced this issue Jan 11, 2025
@droideck
Issue 6490 - Add a new macro function and print rounds on startup
6f86756 
Description: This commit introduces a new macro function (log_error_ext!) to improve logging by providing a way to write a custom subsystem instead of file:line. It also modifies the handle_pbkdf2_rounds_config method to print the PBKDF2 rounds (number of iterations) on startup.

Fixes: 389ds#6490

Reviewed by: ?
@droideck droideck linked a pull request Jan 11, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mreynolds389 mreynolds389

@droideck droideck

Labels
needs triage The issue will be triaged during scrum rust Rust language
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 6490 - Add a new macro function and print rounds on startup droideck/389-ds-base
2 participants
@mreynolds389 @droideck