Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leaks in ldbm_entryrdn.c #6453

Closed
mreynolds389 opened this issue Dec 18, 2024 · 2 comments · Fixed by #6504
Closed

Fix memory leaks in ldbm_entryrdn.c #6453

mreynolds389 opened this issue Dec 18, 2024 · 2 comments · Fixed by #6504
Assignees
@mreynolds389
Labels
needs triage The issue will be triaged during scrum

Comments

@mreynolds389
Copy link
Contributor

Issue Description

There are several memory leaks in ldbm_entryrdn.c with mdb and long DN's

To reproduce run: dirsrvtests/tests/suites/indexes/entryrdn_test.py
@mreynolds389 mreynolds389 added the needs triage The issue will be triaged during scrum label Dec 18, 2024
@mreynolds389 mreynolds389 self-assigned this Dec 18, 2024
mreynolds389 added a commit to mreynolds389/389-ds-base that referenced this issue Dec 19, 2024
@mreynolds389
Issue 6453 - Fix memory leaks in entryrdn
738a5bc 
Description:

We leak memory when processing long DN's (mdb).  We have to loop over
long DN's and on each pass we leak the previous rdn element. In the
tombstone case we just need to free the current childelem

Relates: //github.com/389ds/issues/6453

Reviewed by: ?
mreynolds389 added a commit to mreynolds389/389-ds-base that referenced this issue Dec 19, 2024
@mreynolds389
Issue 6453 - Fix memory leaks in entryrdn
100ec32 
Description:

We leak memory when processing long DN's (mdb).  We have to loop over
long DN's and on each pass we leak the previous rdn element. In the
tombstone case we just need to free the current childelem

Relates: //github.com/389ds/issues/6453

Reviewed by: ?
@mreynolds389 mreynolds389 mentioned this issue Dec 19, 2024
Merged
mreynolds389 added a commit to mreynolds389/389-ds-base that referenced this issue Dec 19, 2024
@mreynolds389
Issue 6453 - Fix memory leaks in entryrdn
c7801b7 
Description:

We leak memory when processing long DN's (mdb).  We have to loop over
long DN's and on each pass we leak the previous rdn element. In the
tombstone case we just need to free the current childelem

Relates: //github.com/389ds/issues/6453

Reviewed by: progier(Thanks!)
mreynolds389 added a commit to mreynolds389/389-ds-base that referenced this issue Jan 7, 2025
@mreynolds389
Issue 6453 - Fix memory leaks in entryrdn
3ea8dcc 
Description:

We leak memory when processing long DN's (mdb).  We have to loop over
long DN's and on each pass we leak the previous rdn element. In the
tombstone case we just need to free the current childelem

Relates: //github.com/389ds/issues/6453

Reviewed by: progier & spichugi(Thanks!!)
mreynolds389 added a commit that referenced this issue Jan 14, 2025
@mreynolds389
Issue 6453 - Fix memory leaks in entryrdn
9e09235 
Description:

We leak memory when processing long DN's (mdb).  We have to loop over
long DN's and on each pass we leak the previous rdn element. In the
tombstone case we just need to free the current childelem

Relates: //github.com//issues/6453

Reviewed by: progier & spichugi(Thanks!!)
mreynolds389 added a commit that referenced this issue Jan 14, 2025
@mreynolds389
Issue 6453 - Fix memory leaks in entryrdn
be58fbe 
Description:

We leak memory when processing long DN's (mdb).  We have to loop over
long DN's and on each pass we leak the previous rdn element. In the
tombstone case we just need to free the current childelem

Relates: //github.com//issues/6453

Reviewed by: progier & spichugi(Thanks!!)
mreynolds389 added a commit that referenced this issue Jan 14, 2025
@mreynolds389
Issue 6453 - Fix memory leaks in entryrdn
ffec756 
Description:

We leak memory when processing long DN's (mdb).  We have to loop over
long DN's and on each pass we leak the previous rdn element. In the
tombstone case we just need to free the current childelem

Relates: //github.com//issues/6453

Reviewed by: progier & spichugi(Thanks!!)
mreynolds389 added a commit that referenced this issue Jan 14, 2025
@mreynolds389
Issue 6453 - Fix memory leaks in entryrdn
6d3ba79 
Description:

We leak memory when processing long DN's (mdb).  We have to loop over
long DN's and on each pass we leak the previous rdn element. In the
tombstone case we just need to free the current childelem

Relates: //github.com//issues/6453

Reviewed by: progier & spichugi(Thanks!!)
@mreynolds389
Copy link
Contributor Author

cea43e0..be58fbe 389-ds-base-3.0 -> 389-ds-base-3.0
39282eb..ffec756 389-ds-base-2.6 -> 389-ds-base-2.6
a303da8..6d3ba79 389-ds-base-2.5 -> 389-ds-base-2.5

tbordaz added a commit to tbordaz/389-ds-base that referenced this issue Jan 15, 2025
@tbordaz
Issue 6453 - (cont) Fix memory leaks in entryrdn
f4294ba 
Bug description:
	Few regression in CI (filter/import/mapping_tree)

Fix description:
	Test a point before deref

fixes: 389ds#6453

Reviewed by:
@tbordaz tbordaz mentioned this issue Jan 15, 2025
Merged
tbordaz added a commit to tbordaz/389-ds-base that referenced this issue Jan 15, 2025
@tbordaz
Issue 6453 - (cont) Fix memory leaks in entryrdn
1c0ef14 
Bug description:
	Few regressions in CI (filter/import/mapping_tree)

Fix description:
	Test a pointer before deref

fixes: 389ds#6453

Reviewed by: Mark Reynolds (Thanks)
tbordaz added a commit that referenced this issue Jan 15, 2025
@tbordaz
Issue 6453 - (cont) Fix memory leaks in entryrdn (#6504)
11f473d 
Bug description:
	Few regressions in CI (filter/import/mapping_tree)

Fix description:
	Test a pointer before deref

fixes: #6453

Reviewed by: Mark Reynolds (Thanks)
tbordaz added a commit that referenced this issue Jan 15, 2025
@tbordaz
Issue 6453 - (cont) Fix memory leaks in entryrdn (#6504)
b03738d 
Bug description:
	Few regressions in CI (filter/import/mapping_tree)

Fix description:
	Test a pointer before deref

fixes: #6453

Reviewed by: Mark Reynolds (Thanks)
tbordaz added a commit that referenced this issue Jan 15, 2025
@tbordaz
Issue 6453 - (cont) Fix memory leaks in entryrdn (#6504)
5451a4a 
Bug description:
	Few regressions in CI (filter/import/mapping_tree)

Fix description:
	Test a pointer before deref

fixes: #6453

Reviewed by: Mark Reynolds (Thanks)
tbordaz added a commit that referenced this issue Jan 15, 2025
@tbordaz
Issue 6453 - (cont) Fix memory leaks in entryrdn (#6504)
60b6a58 
Bug description:
	Few regressions in CI (filter/import/mapping_tree)

Fix description:
	Test a pointer before deref

fixes: #6453

Reviewed by: Mark Reynolds (Thanks)
@tbordaz
Copy link
Contributor

tbordaz commented Jan 15, 2025

7adcd8a..11f473d main
9c2b629..b03738d 389-ds-base-3.0
7f26842..5451a4a 389-ds-base-2.6
856f2bd..60b6a58 389-ds-base-2.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mreynolds389 mreynolds389

Labels
needs triage The issue will be triaged during scrum
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 6453 - (cont) Fix memory leaks in entryrdn tbordaz/389-ds-base
2 participants
@mreynolds389 @tbordaz