Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal flows: Pass actions via props #326

Open
fabriziovigevani opened this issue Sep 3, 2021 · 1 comment
Open

Proposal flows: Pass actions via props #326

fabriziovigevani opened this issue Sep 3, 2021 · 1 comment
Assignees
@juliangnr90 @Harthor

Comments

@fabriziovigevani
Copy link
Member

Actions should be passed via props to Proposal screens instead of getting them by useActions as it will unnecessarily create all action functions again. Actions should have one instance only.
@fabriziovigevani fabriziovigevani self-assigned this Sep 3, 2021
@0xGabi 0xGabi assigned Harthor and unassigned fabriziovigevani Sep 19, 2021
@Harthor
Copy link
Member

Harthor commented Sep 26, 2021

1Hive/gardens-ui#634

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juliangnr90 juliangnr90

@Harthor Harthor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@0xGabi @juliangnr90 @fabriziovigevani @Harthor