From e2605fbc0e2648f0c970619f9dd5380727523301 Mon Sep 17 00:00:00 2001
From: Mitchell Henke <mitchell.henke@gsa.gov>
Date: Tue, 18 Feb 2025 10:22:54 -0600
Subject: [PATCH] Remove some NewRelic method tracing (#11887)

changelog: Internal, Performance, Remove some NewRelic method tracing
---
 app/models/user.rb                              | 3 ---
 app/presenters/confirmation_email_presenter.rb  | 6 ------
 app/services/send_sign_up_email_confirmation.rb | 4 ----
 config/initializers/new_relic_tracers.rb        | 5 -----
 lib/ab_test.rb                                  | 5 -----
 lib/mailer_sensitive_information_checker.rb     | 5 -----
 6 files changed, 28 deletions(-)

diff --git a/app/models/user.rb b/app/models/user.rb
index 242168e2666..e5878e72b1c 100644
--- a/app/models/user.rb
+++ b/app/models/user.rb
@@ -3,7 +3,6 @@
 class User < ApplicationRecord
   include NonNullUuid
 
-  include ::NewRelic::Agent::MethodTracer
   include ActionView::Helpers::DateHelper
 
   devise(
@@ -508,8 +507,6 @@ def send_confirmation_instructions
     # no-op
   end
 
-  add_method_tracer :send_devise_notification, "Custom/#{name}/send_devise_notification"
-
   def analytics
     @analytics ||= Analytics.new(user: self, request: nil, session: {}, sp: nil)
   end
diff --git a/app/presenters/confirmation_email_presenter.rb b/app/presenters/confirmation_email_presenter.rb
index 4fd7e55b8f2..7b6dbfdfdde 100644
--- a/app/presenters/confirmation_email_presenter.rb
+++ b/app/presenters/confirmation_email_presenter.rb
@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
 class ConfirmationEmailPresenter
-  include ::NewRelic::Agent::MethodTracer
-
   def initialize(user, view)
     @user = user
     @view = view
@@ -40,8 +38,4 @@ def confirmation_period
   private
 
   attr_reader :user, :view
-
-  add_method_tracer :initialize, "Custom/#{name}/initialize"
-  add_method_tracer :first_sentence, "Custom/#{name}/first_sentence"
-  add_method_tracer :confirmation_period, "Custom/#{name}/confirmation_period"
 end
diff --git a/app/services/send_sign_up_email_confirmation.rb b/app/services/send_sign_up_email_confirmation.rb
index 62af8f19ecf..62d4a90ea78 100644
--- a/app/services/send_sign_up_email_confirmation.rb
+++ b/app/services/send_sign_up_email_confirmation.rb
@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
 class SendSignUpEmailConfirmation
-  include ::NewRelic::Agent::MethodTracer
-
   attr_reader :user
 
   def initialize(user)
@@ -65,6 +63,4 @@ def send_suspended_user_email
   def handle_multiple_email_address_error
     raise 'sign up user has multiple email address records'
   end
-
-  add_method_tracer :call, "Custom/#{name}/call"
 end
diff --git a/config/initializers/new_relic_tracers.rb b/config/initializers/new_relic_tracers.rb
index 7c66c0d6fa1..bd5a70fefbc 100644
--- a/config/initializers/new_relic_tracers.rb
+++ b/config/initializers/new_relic_tracers.rb
@@ -19,8 +19,3 @@
   add_method_tracer :deliver, "Custom/#{name}/deliver"
   add_method_tracer :deliver!, "Custom/#{name}/deliver!"
 end
-
-SamlIdp::SignedInfoBuilder.class_eval do
-  include ::NewRelic::Agent::MethodTracer
-  add_method_tracer :encoded, "Custom/#{name}/encoded"
-end
diff --git a/lib/ab_test.rb b/lib/ab_test.rb
index dbe70fb8d13..2b367d83d53 100644
--- a/lib/ab_test.rb
+++ b/lib/ab_test.rb
@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
 class AbTest
-  include ::NewRelic::Agent::MethodTracer
-
   attr_reader :buckets,
               :experiment_name,
               :default_bucket,
@@ -173,7 +171,4 @@ def ensure_numeric_percentages
   def within_100_percent?
     valid_bucket_data_structure? && buckets.values.sum <= 100
   end
-
-  add_method_tracer :bucket, "Custom/#{name}/bucket"
-  add_method_tracer :percent, "Custom/#{name}/percent"
 end
diff --git a/lib/mailer_sensitive_information_checker.rb b/lib/mailer_sensitive_information_checker.rb
index ac22a3cdcc2..9bb63b9b269 100644
--- a/lib/mailer_sensitive_information_checker.rb
+++ b/lib/mailer_sensitive_information_checker.rb
@@ -48,9 +48,4 @@ def self.alert(exception)
       raise exception
     end
   end
-
-  class << self
-    include ::NewRelic::Agent::MethodTracer
-    add_method_tracer :check_for_sensitive_pii!, "Custom/#{name}/check_for_sensitive_pii!"
-  end
 end