Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially switch from chokidar to @parcel/watcher or turbowatch #3149

Open
uncenter opened this issue Jan 4, 2024 · 5 comments
Open

Potentially switch from chokidar to @parcel/watcher or turbowatch #3149

uncenter opened this issue Jan 4, 2024 · 5 comments
Labels
enhancement: favorite Vanity label! The maintainer likes this enhancement request a lot. enhancement feature: 🥝 incremental builds

Comments

@uncenter
Copy link
Member

uncenter commented Jan 4, 2024

https://github.com/parcel-bundler/watcher seems like a much better alternative to Choikdar. It's already used by projects like Tailwind, Nx, Nuxt, VSCode, etc (https://github.com/parcel-bundler/watcher#who-is-using-this). Vite considered switching to it but it happened to be too large of a milestone before Vite 5. On that note, https://github.com/gajus/turbowatch also seems interesting. 👀

@zachleat
Copy link
Member

zachleat commented Jan 4, 2024

I’m assuming this should be moved to 11ty/eleventy—the chokidar usage here is strictly for the standalone dev-server CLI. If we change it upstream in Eleventy core, we can talk about applying it to the dev server CLI too!

@zachleat zachleat transferred this issue from 11ty/eleventy-dev-server Jan 4, 2024
@zachleat zachleat changed the title Potentially switch to @parcel/watcher or turbowatch Potentially switch from chokidar to @parcel/watcher or turbowatch Jan 4, 2024
@uncenter
Copy link
Member Author

uncenter commented Jan 4, 2024

Ah okay, makes sense! I thought that was the main watcher in general. Thanks for the correction.

@zachleat
Copy link
Member

Whoa, just saw https://github.com/parcel-bundler/watcher?tab=readme-ov-file#querying which would be a pretty big win for incremental builds.

@murtuzaalisurti
Copy link

does @parcel/watcher support polling though? parcel-bundler/parcel#564

@zachleat
Copy link
Member

Good callout. I have access to WSL for testing, if/when I tackle this one I’ll make sure to test appropriately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement: favorite Vanity label! The maintainer likes this enhancement request a lot. enhancement feature: 🥝 incremental builds
Projects
None yet
Development

No branches or pull requests

3 participants