-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to filter desired terms #50
Comments
I've spent some time thinking about this and putting together an MVP approach locally. I think what I have could work, but we probably want to spend some time discussing UI/UX of this, especially with the plan to redesign the settings pages. On the Image Processing settings page there is a new select box "Filter Automated Tags" with the options "Allowed Tags" and "Disabled Tags", Depending on the selection, another input becomes available. These inputs are controlled by the existing Allowed Tags:By default all existing tags are selected. Users can deselect tags they do not want to be returned. (Is this irrelevant since the tags already exist and can't technically be "disabled"?) The tags fetched are retrieved from the selected "Tag taxonomy" from the same options page. When the form is submitted the NOTE: The duplicate tags found in the search dropdown are not intentional. This is a bug that will be resolved before submitting a PR. Disabled Tags:"Disabled Tags" are saved in an array as strings, exactly as shown. When tags are generated they are compared against this list. If a tag is found in this list it is excluded from the saved tags. If this sounds like an acceptable approach let me know and I'll work to wrap this up and submit a PR. Here is the branch for reference: |
@TylerB24890 Yes there is a larger Settings page revamp coming, but I would not hold on the overall work here as this can be integrated into that revamp work. That being said, I think the approach here makes sense and agree the default behavior would be |
Thanks, @jeffpaul ! I think I can wrap up the main engineering functionality and circle back to the UI portion of it after if we feel the need. I'll work to wrap this up and will follow up after to discuss any needed UI/UX updates. |
Splitting this out from #28:
This would allow site owners to either (1) limit automated tags to existing tags within their site or (2) enter a list of tags that should NOT be saved if they happen to be returned from an AI API (e.g., competitor names).
The text was updated successfully, but these errors were encountered: