-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenAI Image Generation Tweaks #440
Comments
This was already done but found a bug where the CSS we rely on was only included if the IBM Watson feature was on. I've fixed that now in #441.
I agree this would be nice but from what I can tell, there's not a clean way to modify this text. It appears this text comes from the Gutenberg
I also really like this idea, just not sure how hard it will be to achieve. I'd suggest we open this as a separate issue to investigate (perfect opportunity for someone wanting to dive more into Gutenberg).
This has been changed to a
This is also taken care of in #441
There is both an image edit API and image variation API that would be awesome to figure out the best way to integrate those here. I'd suggest those as a separate issue and would be ideal to get some design/UX feedback on how best to trigger that. As far as upscaling goes, no API for that and images have to be either 1024x1024, 512x512 or 256x256 and that size is currently chosen in the settings. We could look to add an inline option allowing you to upscale or downscale to one of those options if we think that would be useful
This is the same as the first point here. We had styling in place for this but the CSS wasn't loading if IBM Watson wasn't enabled. I have tweaked the styling a bit in #441 but I think this is fairly decent now. I wanted the images to be big enough that you can easily see what the image looks like but without them taking up the entire screen. Right now it's typically 4 images in a row, though does depend on your screen size. |
@fabiankagy could use your insight on some of the Gutenberg-related tweaks above ^ and what might be feasible already vs. what we might need to open as an issue upstream in Gutenberg first |
Reading through this issue, I think everything has either been taken care of, can't be changed due to limitations or new issues have been opened (like #723). That said, I do think there are some additional changes we should look to make that I thought we had documented elsewhere but am not finding any issue with these details, so capturing those here. Right now we have four options that can be set when configuring the Image Generation Feature:
Once set, these options are used anytime an image is generated. But there's almost certainly situations where someone would want to change these for an individual generation. For instance, maybe they normally want natural style images but in one scenario, they want a vivid image. Right now they'd have to change the global settings, generate the image, then change the settings back (and this is assuming they have access to change settings). I propose we bring the last three settings into the generate image modal (don't have a mockup for what that would look like but feel like we can iterate on that as this is built). I don't think we need the number of images to be modified, as this has a higher impact on the cost of the request (and technically someone can just make multiple requests if needed). So within the media modal, let's look to add options to set the quality, size and style of the image being generated, defaulting to what is set at the global level. May also make sense to add a new global setting to disable this, in case a site doesn't want individual editors having the ability to change these settings each time they generate an image (noting that image quality and size can impact the cost). |
@dkotter Here is the new mockup based on the request. How does this look? Also, let me know if I should proceed with adding the dropdowns and implementing a new global setting to enable/disable them. |
@faisal-alvi I think that's good enough to start. I could see a UI where these are hidden and we have a button or link to click to
Yes, I think this is good to start work on |
Is your enhancement related to a problem? Please describe.
The following tweaks to our OpenAI image generation functionality would help surface the feature a bit better in the editor as well as make the user flow a bit more akin to the existing Media Library experience within the editor.
1.) Like the
![Screenshot 2023-04-24 at 9 10 32 PM](https://user-images.githubusercontent.com/2818133/234159121-21f67d67-b369-4a07-a867-6fcb79adcb93.png)
Media Library
tab aligns theFilter media
andAll dates
items with theUpload files
horizontal border, it would be great to do the same in theGenerate images
tab with theEnter a prompt...
,Once images...
, andEnter prompt
items.2.) Change the header text of
![Screenshot 2023-04-24 at 9 10 32 PM](https://user-images.githubusercontent.com/2818133/234159121-21f67d67-b369-4a07-a867-6fcb79adcb93.png)
Select or Upload Media
toSelect, Upload, or Generate Media
:3.) Like the
![Screenshot 2023-04-24 at 9 10 32 PM](https://user-images.githubusercontent.com/2818133/234159121-21f67d67-b369-4a07-a867-6fcb79adcb93.png)
Select or Upload Media
modal has options forUpload files
,Media Library
, andGenerate images
, let's update the core image block to haveGenerate image
alongside the currentUpload
,Media Library
,Insert from URL
options that would automatically deep-link into theGenerate images
modal tab.4.) Update the
![Screenshot 2023-04-24 at 9 10 47 PM](https://user-images.githubusercontent.com/2818133/234159136-39650fd1-7c81-459a-b68c-38bdf4ffaf15.png)
Enter prompt
text field to be a larger text area so that lengthy prompt inputs can display more (most?) of the prompt before a user clicks theGenerate images
button.5.) After an image(s) are generated, maintain the prompt input in the
![Screenshot 2023-04-24 at 9 12 17 PM](https://user-images.githubusercontent.com/2818133/234160395-864fb21a-e5ea-4298-bc5f-0fab5e214bdc.png)
Enter prompt
text area in case a user wants to generate different images by tweaking the prompt (e.g. they don't like the options generated and want more to select from). [additionally, if there's an ability in the API to create variants from a specific image result or upscale a certain image, then we should explore that via a separate feature enhancement issue]6.) Regardless of what size image the user has set ClassifAI to generate in the plugin settings, let's only render smaller thumbnail sizes for the results so that however many are returned from OpenAI will easily display alongside eachother (and respective action buttons/links) versus now showing very large images and having to scroll significantly to view all those options.
![Screenshot 2023-04-24 at 9 12 17 PM](https://user-images.githubusercontent.com/2818133/234160395-864fb21a-e5ea-4298-bc5f-0fab5e214bdc.png)
Designs
Screenshots of existing areas for iteration are above, if any suggestions are unclear then let me know and I can hack together samples from those screenshots to try and visually express updates.
Describe alternatives you've considered
n/a
Code of Conduct
The text was updated successfully, but these errors were encountered: