Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper plurals based on image settings #430

Closed
1 task done
dkotter opened this issue Apr 5, 2023 · 0 comments · Fixed by #482
Closed
1 task done

Use proper plurals based on image settings #430

dkotter opened this issue Apr 5, 2023 · 0 comments · Fixed by #482
Assignees
Milestone

Comments

@dkotter
Copy link
Collaborator

dkotter commented Apr 5, 2023

Is your enhancement related to a problem? Please describe.

In #419, we added a feature that allows you to generate one or more images using the OpenAI service and then import one or more images into your media library.

Within the service settings, you can choose how many images should be generated each time you run a prompt. This can be anything from 1 to 10. Within the interface where image generation happens, there's a few places that we just assume multiple images will be generated, like the main tab that says Generate images or the prompt button that says Generate images or the descriptive text that says Enter a prompt below to generate images (and there's a handful of other places as well).

This is a minor thing so may be worth just closing out but we could look to change this text based on the Number of images setting. If that's set to one, change from using plural images to just using image.

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jamesmorrison jamesmorrison self-assigned this Jun 8, 2023
@dkotter dkotter added this to the 2.2.2 milestone Jun 8, 2023
@jeffpaul jeffpaul moved this from Incoming to In Review in Open Source Practice Jun 15, 2023
@dkotter dkotter modified the milestones: 2.2.2, 2.2.3 Jun 27, 2023
dkotter added a commit that referenced this issue Jul 6, 2023
…d-on-image-setting

#430: Use proper plurals based on image settings
@github-project-automation github-project-automation bot moved this from In Review to Merged in Open Source Practice Jul 6, 2023
@vikrampm1 vikrampm1 moved this from Merged to Done/Released in Open Source Practice Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants