Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testing of AdviceMap in Mast #1655

Open
paracetamolo opened this issue Feb 6, 2025 · 0 comments
Open

Improve testing of AdviceMap in Mast #1655

paracetamolo opened this issue Feb 6, 2025 · 0 comments
Assignees
Labels
assembly Related to Miden assembly

Comments

@paracetamolo
Copy link
Contributor

What should be done?

The vendoring PR #1643 should test that the adviceMap of a vendored library is copied to assembled library.
It's not easy to create MAST Forest that contains AdviceMaps using the assembler.

How should it be done?

We should check with the compiler the best way to use the adviceMap.

When is this task done?

We should provide an API to populate the adviceMap, in accordance with how the compiler uses it, and complete the vendoring test.

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assembly Related to Miden assembly
Projects
None yet
Development

No branches or pull requests

1 participant