Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MastForest::merge for one forest does not behave like identity #1644

Open
paracetamolo opened this issue Jan 28, 2025 · 0 comments
Open

MastForest::merge for one forest does not behave like identity #1644

paracetamolo opened this issue Jan 28, 2025 · 0 comments
Labels
assembly Related to Miden assembly bug Something isn't working

Comments

@paracetamolo
Copy link
Contributor

Packages versions

miden-vm: 0.12.0

Bug description

When MastForest::merge takes a single element it should return it unchanged. In some cases like the program built in miden-vm/assembly/src/assembler/tests.rs:nested_blocks the returned forest is different than the original.

This is a minor issue, just documenting it because it caused an unrelated piece of code to fail (the mast vendoring).

How can this be reproduced?

No response

Relevant log output

@paracetamolo paracetamolo added the assembly Related to Miden assembly label Jan 28, 2025
@plafer plafer added the bug Something isn't working label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assembly Related to Miden assembly bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants