Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Multiple tool calls in one completion response are not handled #179

Open
1 task done
vacekj opened this issue Jan 1, 2025 · 3 comments · May be fixed by #224
Open
1 task done

bug: Multiple tool calls in one completion response are not handled #179

vacekj opened this issue Jan 1, 2025 · 3 comments · May be fixed by #224
Labels
breaking
Milestone
2025-03-17

Comments

@vacekj
Copy link

vacekj commented Jan 1, 2025

  • I have looked for existing issues (including closed) about this

Bug Report

Instead of handling all of the tool calls, the current agent impl only handles the first one.

Reproduction

Call a model that returns multiple tool calls, for example the calculator agent with multiple subs and adds

Expected behavior

Rig correctly evaluates all of the tool calls.

Actual behaviour

Rig only evaluates the first tool call.

Fix PR incoming!
@0xMochan
Copy link
Contributor

0xMochan commented Jan 2, 2025

Check out #168 as a potential fix that was deployed specifically for Anthropic!

@edisontim
Copy link
Contributor

Check out #168 as a potential fix that was deployed specifically for Anthropic!

This won't handle that issue, as for the moment the ModelChoice is a single object and not an array. You would need to parse the raw_response to gather all the tool_uses

@vacekj vacekj linked a pull request Jan 20, 2025 that will close this issue
Open
@vacekj
Copy link
Author

vacekj commented Jan 20, 2025 •
edited
Loading

@0xMochan @edisontim here's how I implemented a fix: #224

@cvauclair cvauclair modified the milestones: 2025-02-10, 2025-02-24 Feb 3, 2025
@cvauclair cvauclair modified the milestones: 2025-02-24, 2025-03-17 Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
2025-03-17
Development

Successfully merging a pull request may close this issue.

feat: handle multiple tool calls vacekj/rig
5 participants
@cvauclair @vacekj @edisontim @joshua-mo-143 @0xMochan