feat: handle multiple tool calls #224
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Hey, thanks for this PR. I have a feeling this will greatly break with my upcoming #199 messages refactor. I'll keep an eye our on how this affects this PR and maybe can help rebase / merge from main to assist in the new messages layout. |
|
@0xMochan sure, I will rebase periodically to ease the merge once you merge yours. |
Comment on lines
+226
to
+227
| /// Represents a completion response with multiple tool calls | ||
| MultipleToolCalls(Vec<ModelChoice>), |
There was a problem hiding this comment.
I think this is not correct approach, from the model of OpenAI you can have just one message or 1 to many tool calls:
So I propose something like this:
#[derive(Debug)]
pub enum ModelChoice {
/// Represents a completion response as a message
Message(String),
/// Represents a completion response as a tool call of the form
/// `ToolCall(function_name, id, function_params)`.
ToolCalls(OneOrMany<ToolCall>),
}
pub struct ToolCall {
function_name: String,
id: String,
function_params: serde_json::Value)
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #179
feedback wanted!