Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to declare IPAddress when configuring a Port #313

Open
05nelsonm opened this issue Jan 2, 2024 · 3 comments
Open

Add ability to declare IPAddress when configuring a Port #313

05nelsonm opened this issue Jan 2, 2024 · 3 comments

Comments

@05nelsonm
Copy link
Owner

See #312 (comment)

Would be preferred to have some sort of Localhost object where resolution of the actual loopback IP address can be had.

The configuration should accept IPaddress?

Need to also verify how not including a prefixing IP address will be handled by tor. Documentation states that 127.0.0.1 will be used, which is entirely incorrect.

@05nelsonm 05nelsonm added this to the 2.0.0-alpha01 milestone Jan 2, 2024
@05nelsonm 05nelsonm changed the title Add ability to configure Port IP address Add ability to declare IP address when configuring a Port Jan 3, 2024
@05nelsonm
Copy link
Owner Author

I think this functionality is great, but maybe not necessary until after a 2.0.0-alpha01 release.

I see it as being able to pass in LocalHost.IPv4 or LocalHost.IPv6, as well as maybe another Address type of AnyHost

public sealed class AnyHost private constructor(
    @JvmField
    public val address: IPAddress,
): Address(address.value) {

    public object IPv4: AnyHost("0.0.0.0".toIPAddressV4())
    public object IPv6: AnyHost("::0".toIPAddressV6())
}

@05nelsonm
Copy link
Owner Author

May also want to consider adding the TorConfig settings for IP protocol preferences.

@05nelsonm
Copy link
Owner Author

05nelsonm commented May 28, 2024

Will do this in future 2.x.0 release

@05nelsonm 05nelsonm removed this from the 2.0.0-alpha01 milestone May 28, 2024
@05nelsonm 05nelsonm changed the title Add ability to declare IP address when configuring a Port Add ability to declare IPAddress when configuring a Port May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant