Skip to content

Commit

Permalink
Replace buildSrc with an included build (junit-team#3151)
Browse files Browse the repository at this point in the history
- moved `buildSrc` to `gradle/plugins`
- added `junitbuild` as group to all plugins
- moved build logic classes from `org.junit.gradle` package 
  to `junitbuild` package

Resolves junit-team#3149.
  • Loading branch information
britter authored Feb 16, 2023
1 parent cae2bff commit 4b1de7d
Show file tree
Hide file tree
Showing 59 changed files with 83 additions and 84 deletions.
3 changes: 1 addition & 2 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# Gradle
.gradle
/build/
/*/build/
build

# Ignore Gradle GUI config
gradle-app.setting
Expand Down
12 changes: 6 additions & 6 deletions build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
plugins {
id("io.spring.nohttp")
id("io.github.gradle-nexus.publish-plugin")
`base-conventions`
`build-metadata`
`dependency-update-check`
`jacoco-aggregation-conventions`
`temp-maven-repo`
id("junitbuild.base-conventions")
id("junitbuild.build-metadata")
id("junitbuild.dependency-update-check")
id("junitbuild.jacoco-aggregation-conventions")
id("junitbuild.temp-maven-repo")
}

description = "JUnit 5"
Expand Down Expand Up @@ -61,5 +61,5 @@ nexusPublishing {
}

nohttp {
source.exclude("buildSrc/build/generated-sources/**")
source.exclude("**/.gradle/**", "gradle/plugins/build/generated-sources/**")
}
1 change: 0 additions & 1 deletion buildSrc/settings.gradle.kts

This file was deleted.

6 changes: 0 additions & 6 deletions buildSrc/src/main/kotlin/base-conventions.gradle.kts

This file was deleted.

8 changes: 4 additions & 4 deletions documentation/documentation.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,17 @@ import org.asciidoctor.gradle.base.AsciidoctorAttributeProvider
import org.asciidoctor.gradle.jvm.AbstractAsciidoctorTask
import org.gradle.api.tasks.PathSensitivity.RELATIVE
import org.jetbrains.kotlin.gradle.plugin.KotlinSourceSet
import org.junit.gradle.exec.ClasspathSystemPropertyProvider
import org.junit.gradle.exec.RunConsoleLauncher
import org.junit.gradle.javadoc.ModuleSpecificJavadocFileOption
import junitbuild.exec.ClasspathSystemPropertyProvider
import junitbuild.exec.RunConsoleLauncher
import junitbuild.javadoc.ModuleSpecificJavadocFileOption
import java.io.ByteArrayOutputStream
import java.nio.file.Files

plugins {
id("org.asciidoctor.jvm.convert")
id("org.asciidoctor.jvm.pdf")
id("org.ajoberstar.git-publish")
`kotlin-library-conventions`
id("junitbuild.kotlin-library-conventions")
}

val modularProjects: List<Project> by rootProject
Expand Down
4 changes: 2 additions & 2 deletions buildSrc/build.gradle.kts → gradle/plugins/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ dependencies {

tasks {
withType<JavaCompile>().configureEach {
options.release.set(8)
options.release.set(11)
}
withType<KotlinCompile>().configureEach {
kotlinOptions {
jvmTarget = "1.8"
jvmTarget = "11"
allWarningsAsErrors = true
}
}
Expand Down
Empty file.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
plugins {
eclipse
idea
id("junitbuild.java-toolchain-conventions")
id("junitbuild.spotless-conventions")
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import org.gradle.kotlin.dsl.`jacoco-report-aggregation`
import org.gradle.testing.jacoco.plugins.JacocoCoverageReport

plugins {
id("jacoco-conventions")
id("junitbuild.jacoco-conventions")
`jacoco-report-aggregation`
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import org.gradle.api.attributes.LibraryElements.LIBRARY_ELEMENTS_ATTRIBUTE

plugins {
java
id("jacoco-conventions")
id("junitbuild.jacoco-conventions")
}

val mavenizedProjects: List<Project> by rootProject.extra
Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar
import org.junit.gradle.java.ModulePathArgumentProvider
import org.junit.gradle.java.PatchModuleArgumentProvider
import junitbuild.java.ModulePathArgumentProvider
import junitbuild.java.PatchModuleArgumentProvider

plugins {
`java-library`
eclipse
idea
checkstyle
id("base-conventions")
id("jacoco-java-conventions")
id("junitbuild.base-conventions")
id("junitbuild.jacoco-java-conventions")
}

val mavenizedProjects: List<Project> by rootProject.extra
Expand Down Expand Up @@ -42,8 +42,8 @@ java {

if (project in mavenizedProjects) {

apply(plugin = "publishing-conventions")
apply(plugin = "osgi-conventions")
apply(plugin = "junitbuild.publishing-conventions")
apply(plugin = "junitbuild.osgi-conventions")

java {
withJavadocJar()
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
plugins {
id("java-library-conventions")
id("junitbuild.java-library-conventions")
}

val mavenizedProjects: List<Project> by rootProject.extra
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ dependencies {
strictly("4.12")
}
}
pluginManager.withPlugin("osgi-conventions") {
pluginManager.withPlugin("junitbuild.osgi-conventions") {
val junit4Osgi = requiredVersionFromLibs("junit4Osgi")
"osgiVerification"("org.apache.servicemix.bundles:org.apache.servicemix.bundles.junit:${junit4Osgi}")
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile

plugins {
id("java-library-conventions")
id("junitbuild.java-library-conventions")
kotlin("jvm")
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
plugins {
`maven-publish`
signing
id("base-conventions")
id("junitbuild.base-conventions")
}

val isSnapshot = project.version.toString().contains("SNAPSHOT")
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
plugins {
id("java-library-conventions")
id("junitbuild.java-library-conventions")
id("com.github.johnrengelman.shadow")
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package org.junit.gradle.exec
package junitbuild.exec

import org.gradle.api.file.FileCollection
import org.gradle.api.tasks.Classpath
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package org.junit.gradle.exec
package junitbuild.exec

import org.gradle.api.DefaultTask
import org.gradle.api.file.ConfigurableFileCollection
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package org.junit.gradle.java
package junitbuild.java

import org.gradle.api.Action
import org.gradle.api.Task
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package org.junit.gradle.java
package junitbuild.java

import org.gradle.api.Named
import org.gradle.api.Project
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package org.junit.gradle.java
package junitbuild.java

import javaModuleName
import org.gradle.api.Named
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package org.junit.gradle.java
package junitbuild.java

import org.gradle.api.DefaultTask
import org.gradle.api.artifacts.Configuration
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package org.junit.gradle.javadoc
package junitbuild.javadoc

import org.gradle.external.javadoc.JavadocOptionFileOption
import org.gradle.external.javadoc.internal.JavadocOptionFileWriterContext
Expand Down
2 changes: 1 addition & 1 deletion junit-bom/junit-bom.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
plugins {
`java-platform`
`publishing-conventions`
id("junitbuild.publishing-conventions")
}

description = "${rootProject.description} (Bill of Materials)"
Expand Down
2 changes: 1 addition & 1 deletion junit-jupiter-api/junit-jupiter-api.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
plugins {
`kotlin-library-conventions`
id("junitbuild.kotlin-library-conventions")
`java-test-fixtures`
}

Expand Down
4 changes: 2 additions & 2 deletions junit-jupiter-engine/junit-jupiter-engine.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import org.gradle.api.tasks.PathSensitivity.RELATIVE

plugins {
`kotlin-library-conventions`
`testing-conventions`
id("junitbuild.kotlin-library-conventions")
id("junitbuild.testing-conventions")
groovy
`java-test-fixtures`
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
plugins {
`java-library-conventions`
`junit4-compatibility`
`testing-conventions`
id("junitbuild.java-library-conventions")
id("junitbuild.junit4-compatibility")
id("junitbuild.testing-conventions")
}

description = "JUnit Jupiter Migration Support"
Expand Down
6 changes: 3 additions & 3 deletions junit-jupiter-params/junit-jupiter-params.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
plugins {
`kotlin-library-conventions`
`shadow-conventions`
`testing-conventions`
id("junitbuild.kotlin-library-conventions")
id("junitbuild.shadow-conventions")
id("junitbuild.testing-conventions")
}

description = "JUnit Jupiter Params"
Expand Down
2 changes: 1 addition & 1 deletion junit-jupiter/junit-jupiter.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
plugins {
`java-library-conventions`
id("junitbuild.java-library-conventions")
}

description = "JUnit Jupiter (Aggregator)"
Expand Down
8 changes: 4 additions & 4 deletions junit-platform-commons/junit-platform-commons.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import org.junit.gradle.java.ExecJarAction
import junitbuild.java.ExecJarAction

plugins {
`java-library-conventions`
`java-multi-release-sources`
`java-repackage-jars`
id("junitbuild.java-library-conventions")
id("junitbuild.java-multi-release-sources")
id("junitbuild.java-repackage-jars")
`java-test-fixtures`
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import org.junit.gradle.java.WriteArtifactsFile
import junitbuild.java.WriteArtifactsFile

plugins {
`java-library-conventions`
`shadow-conventions`
id("junitbuild.java-library-conventions")
id("junitbuild.shadow-conventions")
}

description = "JUnit Platform Console Standalone"
Expand Down
10 changes: 5 additions & 5 deletions junit-platform-console/junit-platform-console.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
plugins {
`java-library-conventions`
`shadow-conventions`
`java-multi-release-sources`
`java-repackage-jars`
id("junitbuild.java-library-conventions")
id("junitbuild.shadow-conventions")
id("junitbuild.java-multi-release-sources")
id("junitbuild.java-repackage-jars")
}

description = "JUnit Platform Console"
Expand Down Expand Up @@ -38,7 +38,7 @@ tasks {
into("META-INF")
}
from(sourceSets.mainRelease9.get().output.classesDirs)
doLast(objects.newInstance(org.junit.gradle.java.ExecJarAction::class).apply {
doLast(objects.newInstance(junitbuild.java.ExecJarAction::class).apply {
javaLauncher.set(project.javaToolchains.launcherFor(java.toolchain))
args.addAll(
"--update",
Expand Down
2 changes: 1 addition & 1 deletion junit-platform-engine/junit-platform-engine.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
plugins {
`java-library-conventions`
id("junitbuild.java-library-conventions")
`java-test-fixtures`
}

Expand Down
2 changes: 1 addition & 1 deletion junit-platform-jfr/junit-platform-jfr.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
plugins {
`java-library-conventions`
id("junitbuild.java-library-conventions")
}

description = "JUnit Platform Flight Recorder Support"
Expand Down
2 changes: 1 addition & 1 deletion junit-platform-launcher/junit-platform-launcher.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
plugins {
`java-library-conventions`
id("junitbuild.java-library-conventions")
`java-test-fixtures`
}

Expand Down
4 changes: 2 additions & 2 deletions junit-platform-reporting/junit-platform-reporting.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
plugins {
`java-library-conventions`
`shadow-conventions`
id("junitbuild.java-library-conventions")
id("junitbuild.shadow-conventions")
}

description = "JUnit Platform Reporting"
Expand Down
4 changes: 2 additions & 2 deletions junit-platform-runner/junit-platform-runner.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
plugins {
`java-library-conventions`
`junit4-compatibility`
id("junitbuild.java-library-conventions")
id("junitbuild.junit4-compatibility")
}

description = "JUnit Platform Runner"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
plugins {
`java-library-conventions`
id("junitbuild.java-library-conventions")
}

description = "JUnit Platform Suite API"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
plugins {
`java-library-conventions`
id("junitbuild.java-library-conventions")
}

description = "JUnit Platform Suite Commons"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
plugins {
`java-library-conventions`
id("junitbuild.java-library-conventions")
}

description = "JUnit Platform Suite Engine"
Expand Down
2 changes: 1 addition & 1 deletion junit-platform-suite/junit-platform-suite.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
plugins {
`java-library-conventions`
id("junitbuild.java-library-conventions")
}

description = "JUnit Platform Suite (Aggregator)"
Expand Down
2 changes: 1 addition & 1 deletion junit-platform-testkit/junit-platform-testkit.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
plugins {
`java-library-conventions`
id("junitbuild.java-library-conventions")
}

description = "JUnit Platform Test Kit"
Expand Down
Loading

0 comments on commit 4b1de7d

Please sign in to comment.